Fix QASM3 experimental delay unit serialization#16317
Closed
kelvinvelasquez-SDE wants to merge 1 commit into
Closed
Fix QASM3 experimental delay unit serialization#16317kelvinvelasquez-SDE wants to merge 1 commit into
kelvinvelasquez-SDE wants to merge 1 commit into
Conversation
Correct the exported millisecond suffix and picosecond-to-nanosecond conversion in the experimental QASM3 exporter so delay literals round-trip with the intended units.
|
|
|
|
Member
|
I'm closing this one in favor of #16114, which landed first. Feel free to take any issue from qisk.it/good-first-issues for other first-time-contributor-friendly issues . Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DurationUnit::Millisecondserializer so experimental QASM3 exports emitmsinstead ofusqasm3.dumps_experimentalmsandpsdelay serializationTest plan
python -m unittest test.python.qasm3.test_export.TestQASM3ExporterRust.test_delay_units test.python.qasm3.test_export.TestQASM3ExporterRust.test_delay_qpy_roundtrip test.python.qasm3.test_export.TestCircuitQASM3.test_delay_statementin an isolated validation worktreefixes #16097
AI assistance disclosure: GPT-5.4 (Cursor)